Fixed version format of built packages#5197
Merged
harishsk merged 1 commit intodotnet:masterfrom Jun 3, 2020
harishsk:versionFormatFix
Merged
Fixed version format of built packages#5197harishsk merged 1 commit intodotnet:masterfrom harishsk:versionFormatFix
harishsk merged 1 commit intodotnet:masterfrom
harishsk:versionFormatFix
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5197 +/- ##
==========================================
- Coverage 73.32% 73.31% -0.01%
==========================================
Files 1007 1007
Lines 188386 187969 -417
Branches 20286 20241 -45
==========================================
- Hits 138126 137809 -317
+ Misses 44736 44634 -102
- Partials 5524 5526 +2
|
antoniovs1029
approved these changes
Jun 3, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are no longer using the pre-release tag, our package versions at the daily build have had an improper version string with two hyphens in a row. This PR fixes that issue.
Our version format is not SemVer 2.0.0 compatible because according SemVer v2, the build metadata has to be separated by +. However this causes build warnings and attempting to fix the warnings causes the msbuild Pack task to not include build number in the package name.
That issue has to be resolved separately.